search

supabase / gotrue-dart

A dart client library for GoTrue.
MIT License
46 stars 37 forks source link

fix: export missing types #44

Closed Vinzent03 closed 2 years ago

Vinzent03 commented 2 years ago

What kind of change does this PR introduce?

Bug fix

What is the current behavior?

You cannot define GotrueError or GoTrueClient as type, because it's not exported. In addition, it was not possible to specify custom CookieOptions because the class wasn't exported too.

What is the new behavior?

Files are now properly exported.

Additional context

In addition, I removed unnecessary imports.

I noticed some types begin with GoTrue and some with Gotrue. Wouldn't it be better if the beginning would be equal? Examples:

bdlukaa commented 2 years ago

Wouldn't it be better if the beginning would be equal?

I agree

Vinzent03 commented 2 years ago

In other libraries it's GoTrue, but I think changing GoTrueClient to GotrueClient would affect fewer files than GoTrueSession or GoTrueResponse. Nevertheless, it would be a simple search and replace.

Vinzent03 commented 2 years ago

Besides my raised question, can you merge this? If you want to fix the naming and decided for one variation, I could add that too.