supabase / gotrue-dart

A dart client library for GoTrue.
MIT License
46 stars 37 forks source link

BREAKING: user will be returned when signing up with auto confirm off #63

Closed dshukertjr closed 2 years ago

dshukertjr commented 2 years ago

Currently, with the Dart SDK, when a user signs up and the auto confirm is turned off, the SDK does not returns null for both user and session. This is not the case in js library, so this PR attempts to follow the same behavior in Dart SDK as well.

Closes https://github.com/supabase-community/gotrue-dart/issues/54 Closes https://github.com/supabase-community/supabase-flutter/issues/39

DanMossa commented 2 years ago

This is a breaking change, correct?

dshukertjr commented 2 years ago

@DanMossa Yup, it is. Thanks for flagging it!

bdlukaa commented 2 years ago

I agree with this behavior. There is a flag to check if the email isn't verified, which allows this behavior to be acceptable