Using JWT Decode without External Package

supabase / gotrue-dart

A dart client library for GoTrue.

MIT License

46 stars 37 forks source link

Using JWT Decode without External Package #70

Closed anggoran closed 2 years ago

anggoran commented 2 years ago

Current Behavior

Our gotrue package uses external JWT package

New Behavior

Uses our own minimalist JWT decode file

bdlukaa commented 2 years ago

Why? Is there any performance improvements?

anggoran commented 2 years ago

Actuallu there is no performance improvement, only reducing dependency

dshukertjr commented 2 years ago

@anggoran Thanks for writing up this PR in an attempt to reduce dependency. Personally, I am not so confident if we should make this move as it creates more code for us to maintain.

With that note, I am going to close this particular PR, but please feel free to open PR/issues to discuss potential improvements of the library!