search

supabase / gotrue-dart

A dart client library for GoTrue.
MIT License
46 stars 37 forks source link

Add generateLink method #83

Closed NiKoTron closed 2 years ago

NiKoTron commented 2 years ago

Added generateLink method reffer to the supabase's Auth(Server only) API

bdlukaa commented 2 years ago

I'm not sure we want to expose server APIs to this client library

@dshukertjr

NiKoTron commented 2 years ago

why not? For example, I use dart as a server language. Also there's api key based restriction to use this method, i guess it should be enough.

dshukertjr commented 2 years ago

@bdlukaa I was the one who said let's wait on implementing server side methods on these libraries, because I thought the js library was going to be separated into client side library and server side library on this issue, it hasn't been separated and I checked with the team, but it seems like we don't have immediate plans to separate it (still on the road map at some point though).

With Dart increasing in popularity as a server side language, perhaps we could reconsider it and start adding all the server side methods?

Related https://github.com/supabase-community/gotrue-dart/pull/26

dshukertjr commented 2 years ago

@NiKoTron Could we include a test as well for this amazing work that you have done? https://github.com/supabase/gotrue-js/blob/master/test/GoTrueApi.test.ts#L294

NiKoTron commented 2 years ago

@dshukertjr Sorry for the late reply. I made tests similiar to JS impl. also added dart_jsonwebtoken as a dev_dependency to geneate service jwt.