search

supabase / pg_net

A PostgreSQL extension that enables asynchronous (non-blocking) HTTP/HTTPS requests with SQL
https://supabase.github.io/pg_net
Apache License 2.0
213 stars 16 forks source link

fix: check_worker_is_up #105

Closed steve-chavez closed 11 months ago

steve-chavez commented 11 months ago
soedirgo commented 11 months ago

I'm a bit wary about changing a function's signature. Can we instead create a new function (net.is_worker_up()) and keep the old function as is?

soedirgo commented 11 months ago

We can also print a warning when the old function is run.

steve-chavez commented 11 months ago

Ok, signature is kept as is.

I thought that check_worker_is_up would be confusing if it doesn't return anything. I just added a comment to clarify this.

steve-chavez commented 11 months ago

I'll hold bumping to 0.7.3 after https://github.com/supabase/pg_net/pull/108 is merged