supabase / pgadmin4

Mirror of the pgAdmin 4 GIT repo. DO NOT submit pull requests here! Use the pgadmin-hackers@lists.postgresql.org mailing list. Issues should be logged at https://redmine.postgresql.org/projects/pgadmin4.

https://www.pgadmin.org

Other

12 stars 2 forks source link

Some logging is included in the diff output #24

Open soedirgo opened 2 years ago

soedirgo commented 2 years ago

Bug report

To Reproduce

docker run supabase/pgadmin-schema-diff:cli-0.0.3 '<source>' '<target>' > diff.sql

NOTE: Configuring authentication for DESKTOP mode.
-- Event Trigger: api_restart on database postgres

-- DROP EVENT TRIGGER IF EXISTS api_restart;

CREATE EVENT TRIGGER api_restart ON DDL_COMMAND_END
    EXECUTE PROCEDURE notify_api_restart();

...

Expected behavior

The NOTE: ... line shouldn't be included in the output.

steve-chavez commented 2 years ago

Hm, I made sure to solve this on the first version https://github.com/supabase/pgadmin4/blob/dc8e6288ff810af438f475534f73aa124c7ccc27/web/cli.py#L376-L379

A regression must have happened

soedirgo commented 2 years ago

FTR right now I'm working around it by trimming the first line.