supabase / postgres

Unmodified Postgres with some useful plugins
https://supabase.com
PostgreSQL License
1.34k stars 135 forks source link

Update supautils.conf.j2 | exempted net and logging variables #1069

Closed TheOtherBrian1 closed 2 weeks ago

TheOtherBrian1 commented 1 month ago

What kind of change does this PR introduce?

Modified supautils configs

What is the current behavior?

pg_net variables and the log_lock_waits variable cannot be configured by users.

What is the new behavior?

Allows users to configure pg_net variables (other than database):

Gives users permission to log locks that last for more than 1s

Additional context

Add any other context or screenshots.

steve-chavez commented 4 weeks ago

Hm, wait. Is this config applicable now that we use the Nix build?

olirice commented 4 weeks ago

@samrose It doesn't look like the settings in supautils.conf are being applied (maybe only a local thing) but

postgres=# set pg_net.ttl = '1s'
ERROR:  parameter "pg_net.ttl" cannot be changed now
samrose commented 4 weeks ago

@samrose It doesn't look like the settings in supautils.conf are being applied (maybe only a local thing) but

postgres=# set pg_net.ttl = '1s'
ERROR:  parameter "pg_net.ttl" cannot be changed now
  • is that the correct location for supautils config?
    • does it apply locally?

I think you are right that those settings have not been wired in yet on local testing

I’ll be back in front of computer in a few and will get it working in local testing context

samrose commented 3 weeks ago

We did recently merge in a pr to develop that correctly used all of our configurations and migrations

https://github.com/supabase/postgres/pull/1130

soedirgo commented 2 weeks ago

cc @supabase/backend for a +1