search

supabase / postgrest-dart

Dart client for PostgREST
https://supabase.com
MIT License
136 stars 38 forks source link

fix: `delete()` now does not return data by default and comments cleanup #105

Closed dshukertjr closed 1 year ago

dshukertjr commented 1 year ago

While I was cleaning up the comments, I noticed that delete() still returns the deleted value by default. I have updated the code so that it does not return value by default.

Vinzent03 commented 1 year ago

Isn't this a breaking change? I think we have to wait for this until v2.

dshukertjr commented 1 year ago

@Vinzent03 I thought so at first as well, but I think it might not be breaking, because .delete() currently returns a PostgrestFilterBuilder<void>, so even though the API had returned the deleted values, as far as this client library is concerned, there was no return value.

Vinzent03 commented 1 year ago

Oh interesting! I think that's fine then. There seem some formatting issues on later sdks to exist, but I think that's fine.