Fix code samples of methods

supabase / postgrest-dart

Dart client for PostgREST

https://supabase.com

MIT License

136 stars 38 forks source link

Fix code samples of methods #29

Closed kaboc closed 3 years ago

kaboc commented 3 years ago

What kind of change does this PR introduce?

Docs update.

What is the current behavior?

N/A

What is the new behavior?

No change.

Additional context

Named parameters: Curly braces were removed.
Maps: Improved to follow the dart style.

kaboc commented 3 years ago

https://github.com/supabase/postgrest-dart/blob/23316bd6ff4c6a35717d7b6dd4220c0b97394b70/lib/src/postgrest_query_builder.dart#L73-L78

What does the {upsert: true} mean? The second argument of upsert() is a named parameter with the name onConflict. I was not sure about it, so please tell me if this should be fixed too.

kaboc commented 3 years ago

I found that insert() has the upsert flag. Having it in the code sample of upsert() is wrong.

phamhieu commented 3 years ago

Thanks @kaboc