search

supabase / postgrest-dart

Dart client for PostgREST
https://supabase.com
MIT License
136 stars 38 forks source link

Transform builder foreign table bug adds quotations around foreign table url query #72

Closed Certinax closed 2 years ago

Certinax commented 2 years ago

Problem

Using Order, Limit or Range on foreign tables will add extra quotation "" around the queried tables resulting in Postgrest error when it's being used on nested foreign tables.

This issue was originally reported in the supabase-flutter repository. I was able to track down where the bug was and has now been fixed. I also added tests and mock table/data for validating the issue. For a full explanation of the issue: https://github.com/supabase-community/supabase-flutter/issues/104#issue-1226036857.

⚠️ Added Collection to dev dependencies for test validation -- used for list utilities.


This is my first time contributing to open source, so hope I don't break too many rules with this pull request 😅

Fixes https://github.com/supabase-community/supabase-flutter/issues/104

dshukertjr commented 2 years ago

@Certinax Almost forgot about it! We like to send swags to contributors of Supabase to show our appreciations. If you could send me a DM on Twitter, I will send you a swag code to ship you some Supabase swags if you would like! https://twitter.com/dshukertjr

Certinax commented 2 years ago

@Certinax This is amazing! Thank you so much for the great work, and sorry that I wasn't able to tackle this one in a timely manner as promised.

@dshukertjr This is really cool -- I'm glad I could help out with this one!