search

supabase / realtime

Broadcast, Presence, and Postgres Changes via WebSockets
https://supabase.com/realtime
Apache License 2.0
6.83k stars 315 forks source link

fix: Move migrations to non blocking callback #1227

Closed filipecabaco closed 2 days ago

filipecabaco commented 1 week ago

What kind of change does this PR introduce?

Moves migrations to a non blocking callback meaning that multiple migrations will be able to be started. We're also handling errors better when the migrations are already running preventing multiple migrations from starting

vercel[bot] commented 1 week ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **realtime-demo** | ⬜️ Ignored ([Inspect](https://vercel.com/supabase/realtime-demo/HqM9z7c6xvKxfKcHfbyVdKbLDAsu)) | [Visit Preview](https://realtime-demo-git-fix-handle-continue-migrations-supabase.vercel.app) | | Nov 19, 2024 3:09pm |
filipecabaco commented 2 days ago

For now we opted to avoid this change as it requires a lot of "sleep" which is a smell. If we moved forward with this change we could find serious issues in production due to multiple async migrations happening