search

supabase / setup-cli

A GitHub action for interacting with your Supabase projects using the CLI.
MIT License
120 stars 16 forks source link

chore: simplify an example of diff checking #69

Closed y-yagi closed 2 years ago

y-yagi commented 2 years ago

What kind of change does this PR introduce?

docs

Additional context

The original sample hides the result of git diff. So if git diff returns an error(e.g. invalid file name specified), the result will be success.

We can use --exit-code option if we only want to know whether differences exist without depending on other commands. Ref: https://git-scm.com/docs/git-diff#Documentation/git-diff.txt---exit-code

sweatybridge commented 2 years ago

Thanks for the suggestion. Can we update the ci workflow as well please https://github.com/supabase/setup-cli/blob/e18397b05b9fde7bd221839c35e1c36e9bddb1b2/.github/workflows/check-dist.yml#L41

y-yagi commented 2 years ago

Thanks for your review. I fixed check-dist.yml too.