search

supabase / splinter

Supabase Postgres Linter
https://supabase.github.io/splinter/
67 stars 6 forks source link

Space at end of column name. #76

Closed GaryAustin1 closed 1 month ago

GaryAustin1 commented 1 month ago

It is still a common occurrence users get a space at the end of a column name. This is extremely hard to spot in the UI and in the table definition it generates as there are not "" around the names. Example: https://github.com/orgs/supabase/discussions/26023

Might be good to flag column names with a space at the end as I cannot think of a good use case for that.

olirice commented 1 month ago

thanks

I've added some metadata collection to the data eng pipeline to check how many instance of these exist. If its a common problem (more than 100 unique projects) we'll add it

I'll follow up nlt Wednesday once that data has been collected

GaryAustin1 commented 1 month ago

Turns out the latest OP was running an older version of the CLI with a studio that did not have the trimming in it.

olirice commented 1 month ago

in that case, should we close this? or is it still worth scanning to see if anyone else is impacted?

GaryAustin1 commented 1 month ago

I would scan. Not sure what other ways it could get in there and the dashboard table UI does not really show trailing spaces.

When it happens it takes a lot of time to figure it out as everything looks correct.

olirice commented 1 month ago

We currently have 0 impacted projects in the hosted environment so I'm going to close this for now. lmk if you see another one come by