supabase / splinter

Supabase Postgres Linter: Performance and Security Advisors
https://supabase.github.io/splinter/
86 stars 7 forks source link

Update advice for Auth RLS Initialization Plan #97

Closed cyluss closed 2 months ago

cyluss commented 2 months ago

Improve documentation

Link

0003 auth rls initplan

Describe the problem

  1. The document suggests 'Call functions with select' from RLS performance recommendation guide but the recommendation does not resolve lint error.
  2. Readers might not know if RLS performance recommndation exists, since readers are navigated from Supabase Studio in the performance advisor.

Describe the improvement

  1. Suggest 'Use security definer functions' instead.
  2. Add Reference section and link to RLS performance recommedation.

Additional context

supabase/supabase#23185

olirice commented 2 months ago

The document suggests 'Call functions with select' from RLS performance recommendation guide but the recommendation does not resolve lint error.

could you please provide a reproducible example for me to test with?

Suggest 'Use security definer functions' instead.

I don't understand this recommendation. There are no functions involved with table access or RLS. Could you please expand on that?

cyluss commented 2 months ago

Sorry for the confusion, this issue is invalid and related issue (supabase/supabase#23185) is not reproducible and closed