supabase / supabase-flutter

Flutter integration for Supabase. This package makes it simple for developers to build secure and scalable products.
https://supabase.com/
MIT License
718 stars 169 forks source link

Keycloak provider in signInWithIdToken method in the gotrue package #1045

Open Ppito opened 1 week ago

Ppito commented 1 week ago

I'm using Keycloak as my authentication provider and we need to use the signInWithIdToken method in our implementation. The problem is that the gotrue package limits this method to the Google, Apple and Kakao providers : gotrue_client.dart Looking at the NodeJs implementation of this same package and function, I noticed that there was no particular blockage to using the Keycloak provider : GoTrueClient.ts.

And indeed, by authorising Keycloak it works without any problem.

So my question is this: can you add this provider to the list of authorised providers?

dshukertjr commented 1 week ago

Sure, would you like to open a PR? Note that it seems like Keycloak is deprecated on the JS library, so there might be chances that it won't be supported in the future.

Ppito commented 1 week ago

I'll be unavailable for the next 3 weeks, so if no-one in my team has done a PR I'll do it when I get back.

Keycloak is not deprecated, quite the contrary. He has joined the Cloud Native Computing Foundation and is strongly supported by the RedHat team. They have restructured the various dev/tools they had and the old SDK is effectively deprecated but not the new one.