search

supabase / supabase-flutter

Flutter integration for Supabase. This package makes it simple for developers to build secure and scalable products.
https://supabase.com/
MIT License
711 stars 168 forks source link

in "Site URL" and "redirectTo" don't use "_" package name. #843

Closed lightofjeju closed 7 months ago

lightofjeju commented 7 months ago

Describe the bug A clear and concise description of what the bug is.

To Reproduce Steps to reproduce the behavior:

  1. Put "_" in the name of the package.
  2. https://supabase.com/dashboard/project/tpagdfpibubnmmjfdlnh/auth/url-configuration, put _ in the "Site URL" value and save it.
  3. Call the await supabase.auth.signInWithOAuth().

Expected behavior A clear and concise description of what you expected to happen.

Screenshots

image

Version (please complete the following information): flutter 3.13.9 supabse_flutter ^2.3.3

dshukertjr commented 7 months ago

@lightofjeju There are a lot of issues with using underscores in a package name and URLs outside the scope of Supabase. Generally, they should be avoided.

https://developers.google.com/search/docs/crawling-indexing/url-structure https://www.reddit.com/r/androiddev/comments/9mckjf/package_name_underscore_problem/

lightofjeju commented 7 months ago

@dshukertjr

Thank you. I think it's good to state that if underbar goes in, it shouldn't be used!

Thank you for making a good service.

dshukertjr commented 7 months ago

Thanks for the feedback. I will try to add it in the docs and readme.