search

supabase / supabase-flutter

Flutter integration for Supabase. This package makes it simple for developers to build secure and scalable products.
https://supabase.com/
MIT License
656 stars 154 forks source link

fix(gotrue): Signing in does not remove the session unless the operation succeeds. #945

Closed dshukertjr closed 1 week ago

dshukertjr commented 1 week ago

What kind of change does this PR introduce?

Bug fix

What is the current behavior?

Currently, the SDK removes the session whenever a user tries to sign-in / sign-up. If the operation fails, the user is signed out from the original session they had. This PR fixes the behavior so that the session is not removed.

What is the new behavior?

The user's session is not removed at the beginning of calling sign-in / sign-up methods, and they will keep the existing session if the sign-in / sign-up operation fails.

Additional context

JS PR: https://github.com/supabase/auth-js/pull/915

dshukertjr commented 1 week ago

Just noticed that there are a bunch of errors on the tests. Looking into it right now.