Updates are not working

[zlwaterfield]

Bug report

Describe the bug

I am running an update on a single row in the table wedding and it is 404ing. I've confirmed I am using the correct id and table. It seems the request being made is not correct.

Here is the code:

  async update(weddingId, wedding) {
    // weddingId = c81c8ab3-9fc5-41d6-9a68-843109ba95b0
    // wedding = {slug: "yes-"}
    return await SupabaseService
      .from<Wedding>('wedding')
      .update(wedding)
      .eq('id', weddingId);
  }

The request url is:

https://wqzrlmhkwwtfqmbwirha.supabase.co/rest/v1/wedding?slug=eq.y&id=neq.c81c8ab3-9fc5-41d6-9a68-843109ba95b0&slug=eq.ye&id=neq.c81c8ab3-9fc5-41d6-9a68-843109ba95b0&slug=eq.yes&id=neq.c81c8ab3-9fc5-41d6-9a68-843109ba95b0&slug=eq.yes-&id=neq.c81c8ab3-9fc5-41d6-9a68-843109ba95b0&id=eq.c81c8ab3-9fc5-41d6-9a68-843109ba95b0

If you break that down:

> queryString.parse('?slug=eq.y&id=neq.c81c8ab3-9fc5-41d6-9a68-843109ba95b0&slug=eq.ye&id=neq.c81c8ab3-9fc5-41d6-9a68-843109ba95b0&slug=eq.yes&id=neq.c81c8ab3-9fc5-41d6-9a68-843109ba95b0&slug=eq.yes-&id=neq.c81c8ab3-9fc5-41d6-9a68-843109ba95b0&id=eq.c81c8ab3-9fc5-41d6-9a68-843109ba95b0')
[Object: null prototype] {
  '?slug': 'eq.y',
  id: [
    'neq.c81c8ab3-9fc5-41d6-9a68-843109ba95b0',
    'neq.c81c8ab3-9fc5-41d6-9a68-843109ba95b0',
    'neq.c81c8ab3-9fc5-41d6-9a68-843109ba95b0',
    'neq.c81c8ab3-9fc5-41d6-9a68-843109ba95b0',
    'eq.c81c8ab3-9fc5-41d6-9a68-843109ba95b0'
  ],
  slug: [ 'eq.ye', 'eq.yes', 'eq.yes-' ]
}

Why are both neq and eq being applied and why is neq there 4 times? Also, why is slug there? The slug was not included in the filter, just in the body.

Screenshots

System information

• Version of supabase-js: v0.36.4
• Version of Node.js: v12.12.0

[zlwaterfield]

I will close this for now, I haven’t experienced this since I opened it and I am not sure how it happened. If I see it again I will create a repo to replicate it.

[kiwicopple]

Here were the ideas discussed on Slack, in case it gets reopened:

• it could be caused by the way the library / code is set up - SupabaseService indicates that you’re somehow adding filters to the query from some other area of your app before executing the call with select() / update() etc.
• could be caused by an auto-reloading dev environment and that is somehow caching the filters each reload

[surjithctly]

What's the possible fix for this? I'm getting same 404 error on a Next.js app. I tried after yarn build but same.

[KevTale]

I'm having the same behaviour with update method and I'm also using Next.js.

    let { data: profiles, error } = await supabase
        .from("profiles")
        .select("*")
        .eq("id", "f4a2d4dd-4aec-4af6-8ba9-9556be7349c3");

works fine.

But this does not (404 error):

     let { data: profiles, error } = await supabase
        .from("profiles")
        .update({ username })
        .eq("id", "f4a2d4dd-4aec-4af6-8ba9-9556be7349c3");

Having a 404 error. The endpoint is https://url.supabase.co/rest/v1/profiles?id=eq.f4a2d4dd-4aec-4af6-8ba9-9556be7349c3

[KushibikiMashu]

Same here. I'm using "@supabase/supabase-js": "^1.24.0" with Next.js.

This works.

const { data, error } = await supabase
  .from('post_likes')
  .select()
  .match({ post_id: postId, account_id: accountId })

// console.log(data)
[
    {
        "postId": 1,
        "accountId": 1,
        "read": false
    }
]

But this doesn't work.

const { data, error } = await supabase
  .from('post_likes')
  .update({
    read: true,
  })
  .match({ post_id: postId, account_id: accountId })

// console.log(data, error)
null []

The response status of PUT /rest/v1/post_likes?post_id=eq.1&account_id=eq.1 is 404.

GET and DELETE methods are ok.

[KushibikiMashu]

I solved this problem by myself. There was something wrong with the update policy.

create policy "Users can update their own like."
  on comment_likes for update with check ( auth.role() = 'authenticated' );

I changed with check to using.

create policy "Users can update their own like."
  on comment_likes for update using ( auth.role() = 'authenticated' );

Then, update from JS works.

[AgarwalPragy]

For anyone facing similar issues with other update queries, please note that

• Existing table rows are checked against the expression specified in USING
• New rows that would be created via INSERT or UPDATE are checked against the expression specified in WITH CHECK

https://www.postgresql.org/docs/current/sql-createpolicy.html

[EskelCz]

@AgarwalPragy You mean INSERT or UPSERT, right? I thought that UPDATE cannot add a new row.

[AgarwalPragy]

@AgarwalPragy You mean INSERT or UPSERT, right? I thought that UPDATE cannot add a new row.

That is a little confusing actually. I just quoted the line direct from the postgres docs: https://www.postgresql.org/docs/current/sql-createpolicy.html

It explicitly says

... while new rows that would be created via INSERT or UPDATE are checked against the expression specified in WITH CHECK ...

Probably means "rows that are created as a side effect of the update operation" - in case of triggers for example.