fix: Use class methods instead of bound arrow functions for rest calls

supabase / supabase-js

An isomorphic Javascript client for Supabase. Query your Supabase database, subscribe to realtime events, upload and download files, browse typescript examples, invoke postgres functions via rpc, invoke supabase edge functions, query pgvector.

https://supabase.com

MIT License

2.86k stars 220 forks source link

fix: Use class methods instead of bound arrow functions for rest calls #973

Closed kamilogorek closed 3 months ago

kamilogorek commented 3 months ago

rest is already PostgrestClient<Database, SchemaName>, so all return types should be infered in the same way as before without using explicit return types.

(I changed FnName and Fn so it fits on one line, as VSCode is messing up syntax highlighting when generics are split into multiple lines 👀 )

coveralls commented 3 months ago

Pull Request Test Coverage Report for Build 7885533013

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.5%) to 65.385%

Totals
Change from base Build 7628728487:	-0.5%
Covered Lines:	89
Relevant Lines:	116

💛 - Coveralls

benaduggan commented 3 months ago

Upgrading to this version blew up the types for me 👀 Am I doing something wrong? or did this PR have unintended consequences?

Lots of things like this:

peterje commented 3 months ago

Upgrading to this version blew up the types for me 👀 Am I doing something wrong? or did this PR have unintended consequences?

Lots of things like this:

Bump. This change broke my team's CI today.

soedirgo commented 3 months ago

Sorry about that! This should be fixed in v2.39.6, can you give it a try?