Replace to HTTPTypes Components from Helpers Components

supabase / supabase-swift

A Swift client for Supabase

https://supabase.com/docs/reference/swift

MIT License

720 stars 111 forks source link

Replace to HTTPTypes Components from Helpers Components #564

Closed zunda-pixel closed 1 month ago

zunda-pixel commented 1 month ago

Description

HTTP Header

Remove Helpers.HTTPHeader
Add HTTPTypes.HTTPFields

HTTP Method

Remove Helpers.HTTPMethod
Add HTTPTypes.HTTPRequest.Method

grdsdev commented 1 month ago

Hi @zunda-pixel thats a nice change, I was waiting for adopting HTTPTypes until they found a way of representing the body too, then I'd also adopt HTTPRequest from HTTPTypes too.

But yeah, I think we can start by migrating the HTTPHeaders, and then migrate HTTPRequest/HTTPResponse in a new PR, or wait until they have the body also represented.

zunda-pixel commented 1 month ago

Hi! @grdsdev I tried to replace HTTPRequest, but It is hard... Yes, HTTPTypes.HTTPRequest has no body. I replaced HTTP Header and HTTP Method