search

supabase / ui

Supabase UI Library
ui-storybook-pre-release.vercel.app
MIT License
1.57k stars 156 forks source link

`Input` component hiding of error icon #311

Open Ziinc opened 2 years ago

Ziinc commented 2 years ago

Would be great to have a prop to hide the error icon, currently it shows by default, which in some situations (see below) would make the input bar actions area even more cluttered. Currently no way to hide it once the error prop is provided.

image

MildTomato commented 2 years ago

great idea!

FatumaA commented 2 years ago

@MildTomato Can I try this one? Also, shouldn't the error icon be with the error msg instead of within the input component?

MildTomato commented 2 years ago

It might be best to avoid changing anything right now in master branch

I'm about to merge a huge change into the alpha branch, so it might be better to work on changes for this on that branch since I think a lot of the actions container has been refactored.

MildTomato commented 2 years ago

@FatumaA I think the best action to take might be to just add a new prop, like hideErrorIcon which would stop the icon appearing altogether when error prop is used.

FatumaA commented 2 years ago

Ok, thanks @MildTomato, I will go ahead and attempt a fix for this then

FatumaA commented 1 year ago

Is this still an issue? I'd be happy to take another look 🤭

ak708 commented 8 months ago

Is this issue still open?