supabase / wrappers

Postgres Foreign Data Wrapper development framework in Rust.

http://fdw.dev

Apache License 2.0

562 stars 56 forks source link

fix: remove `unwrap()` from stats related functions #289

Closed burmecia closed 4 months ago

burmecia commented 5 months ago

What kind of change does this PR introduce?

This PR is to remove unwrap() call from stats related functions. This also caused failure when using API to access foreign tables in some cases.

What is the current behavior?

Currently, it is hard to troubleshot when the panic is caused by unwrap() call.

What is the new behavior?

Replace unwrap() with expect() or remove it if possible.

Additional context

N/A

burmecia commented 5 months ago

290 is to fix the test failure

dohooo commented 4 months ago

@burmecia, thanks for your work. Where can I follow the updates of the new release?

burmecia commented 4 months ago

We're preparing a new release and it should be ready soon, you can check it on the release page. Just a note once the new version of Wrappers is release it sill needed to be included in Supabase Postgres image to available on Supabase platform, this will take some time.

dohooo commented 4 months ago

@burmecia I can confirm this problem still happens. I've tried to upgrade our service to the latest version(15.1.1.76). But I still need to execute the SQL in the studio client; otherwise, the call via JS SDK will fail.

dohooo commented 4 months ago

@burmecia Does this version(15.1.1.76) include this change?

burmecia commented 4 months ago

@burmecia Does this version(15.1.1.76) include this change?

not yet, that 15.1.1.74-wrapper tag was for integration testing, it cannot be used. But the latest Wrappers v0.4.1 has just been merged, it will be available on the next release of Supabase Postgres.