Development of high wing models

[florentLutz]

This PR aims at adding all the components necessary for the sizing of a high wing aircraft. The work necessary to complete this PR:

• [x] Check that the variable in the new module and stability derivative (for twist and dihedral) have the same name
• [x] Ensure same twist convention
• [x] Remove math import
• [x] Rework the compute wing z
• [x] Test the compute wing z
• [x] Test the computation of wing weight with high wing configuration
• [x] Check effect on VLM and OpenVSP modules, twist dihedral and wing position
• [x] Include twist and dihedral effect in the relevant stability derivative module
• [x] Add partials to the new modules
• [x] Check unit tests
• [x] Check integration tests

[florentLutz]

To sum it up this PR brings the following:

• An implementation of the high wing configuration which impacts the aircraft through a higher fuselage and LG mass, an impact on the longitudinal aerodynamics and an impact on the lateral stability derivatives
• The completion of the implementation of twist and dihedral which are now also considdered in the longitudinal aerodynamics
• A meaningful but transparent change in the computation and usage of the Cl = f(y) curve. It used to be computed at an AOA of 0 and be scaled according to CL0 when it needed to be used. This has now changed because of the twist which could lead to negative Cl which would then bias the scale up of the curve. Now, instead we take the curve at the INPUT_AOA and the corresponding Cl is outputed under "data:aerodynamics:wing:low_speed:CL_ref". Small difference on the results when it is used but not meaningful. This however means that the scale down is not really possible for the same reason, maybe two curves should be outputed.
• We removed the requirement on OpenMDAO's max version

Small last precision for the records, most of this work was originally from @fomra

[florentLutz]

Hello, I added the change you suggested, as for the answers to your remarks:

Also, the test test_advance_cl(), doesn't seem to work, probably due to an error in the input file.

The error was actually due to the from_problem method in fast-oad-core which used to return shape_by_conn and copy_shape method but which does not do it anymore in the newest version. It was fixed by bypassing this function to use directly the get_io_metadata function from OpenMDAO instead

Also to be noted, the tests output logs are filled with OpenMDAO warnings about partials derivatives checking. Maybe there is something to double check, otherwise it makes it difficult to read.

Checking the output log, the problem was coming from the fact that we were checking the partials we were computing with finite difference with finite difference. These modules should be avoided now and the logs be clearer.

[codecov-commenter]

Codecov Report

Merging #202 (c1d570e) into main (461b87a) will decrease coverage by 0.10%. The diff coverage is 74.08%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #202      +/-   ##
==========================================
- Coverage   85.16%   85.06%   -0.10%     
==========================================
  Files         365      368       +3     
  Lines       26368    26609     +241     
  Branches     1444     1448       +4     
==========================================
+ Hits        22456    22635     +179     
- Misses       3607     3667      +60     
- Partials      305      307       +2     

Impacted Files	Coverage Δ
...dels/aerodynamics/external/openvsp/compute_aero.py	15.84% <0.00%> (-0.66%)	:arrow_down:
...ga/models/aerodynamics/external/openvsp/openvsp.py	5.35% <0.00%> (-0.15%)	:arrow_down:
.../external/propeller_code/compute_propeller_aero.py	98.03% <ø> (ø)
...dynamics/external/propeller_code/propeller_core.py	94.81% <ø> (ø)
...a/models/aerodynamics/external/vlm/compute_aero.py	15.43% <0.00%> (-0.43%)	:arrow_down:
...s/aerodynamics/unitary_tests/test_beechcraft_76.py	84.84% <ø> (ø)
...els/aerodynamics/unitary_tests/test_cirrus_sr22.py	84.04% <ø> (ø)
src/fastga/models/aerodynamics/external/vlm/vlm.py	8.20% <3.03%> (+0.09%)	:arrow_up:
...ass_breakdown/a_airframe/a5_landing_gear_weight.py	91.89% <40.00%> (-8.11%)	:arrow_down:
.../aerodynamics/unitary_tests/test_partenavia_p68.py	57.14% <57.14%> (ø)
... and 33 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more