supaero-aircraft-design / FAST-GA

FAST-(OAD)-GA is a framework for performing rapid Overall Aircraft Design for General Aviation Aircraft
GNU General Public License v3.0
30 stars 22 forks source link

Bug correction for new package version #211

Closed florentLutz closed 9 months ago

florentLutz commented 9 months ago

This PR corrects a few lines of code which cause incompatibilities with some new versions of some package (OpenMDAO and numpy) which caused new installation of the code to not work. Also added pyparsing as a main dependency (used to be a dev dependency) because otherwise we can't use OpenVSP. I would like to integrate those change to a new release as soon as possible

codecov-commenter commented 9 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (7592439) 85.06% compared to head (43f239f) 85.06%. Report is 9 commits behind head on main.

Files Patch % Lines
...qualities/tail_sizing/compute_to_rotation_limit.py 87.50% 1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #211 +/- ## ========================================== - Coverage 85.06% 85.06% -0.01% ========================================== Files 368 368 Lines 26609 26603 -6 Branches 1448 1447 -1 ========================================== - Hits 22635 22629 -6 Misses 3667 3667 Partials 307 307 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.