Closed florentLutz closed 7 months ago
Attention: Patch coverage is 91.23932%
with 205 lines
in your changes are missing coverage. Please review.
Project coverage is 85.61%. Comparing base (
80a0328
) to head (04c50cd
). Report is 120 commits behind head on main.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
The turboprop model was reworked as an OpenMDAO problem rather than relying on scioy to compute fuel consumption and max thrust. Consequently we now have nested problem that are stored as class attributes of the BasicTurbopropEngine. A significant work was done to ensure that these problem are only setup when needed and only once. Also to do subsequent computation we don't "reset" the problem so it is already "warm started". Implemented a pseudo cache for the max thrust function