supaero-aircraft-design / FAST-GA

FAST-(OAD)-GA is a framework for performing rapid Overall Aircraft Design for General Aviation Aircraft
GNU General Public License v3.0
30 stars 22 forks source link

Optimization of turboprop model #217

Closed florentLutz closed 7 months ago

florentLutz commented 7 months ago

The turboprop model was reworked as an OpenMDAO problem rather than relying on scioy to compute fuel consumption and max thrust. Consequently we now have nested problem that are stored as class attributes of the BasicTurbopropEngine. A significant work was done to ensure that these problem are only setup when needed and only once. Also to do subsequent computation we don't "reset" the problem so it is already "warm started". Implemented a pseudo cache for the max thrust function

codecov-commenter commented 7 months ago

Codecov Report

Attention: Patch coverage is 91.23932% with 205 lines in your changes are missing coverage. Please review.

Project coverage is 85.61%. Comparing base (80a0328) to head (04c50cd). Report is 120 commits behind head on main.

Files Patch % Lines
.../fuel_propulsion/basicTurbo_prop/basicTP_engine.py 68.83% 125 Missing and 9 partials :warning:
...prop_components/turboshaft_off_design_max_power.py 66.01% 35 Missing :warning:
.../basicTurbo_prop_map/basicTP_engine_constructor.py 5.55% 17 Missing :warning:
...cTurbo_prop_map/unitary_tests/test_daher_tbm900.py 0.00% 12 Missing :warning:
...lsion/basicTurbo_prop_map/basicTP_engine_mapped.py 93.33% 3 Missing :warning:
...prop_components/turboshaft_geometry_computation.py 97.40% 0 Missing and 2 partials :warning:
...turboprop_components/turboshaft_off_design_fuel.py 97.72% 0 Missing and 2 partials :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #217 +/- ## ========================================== + Coverage 85.09% 85.61% +0.52% ========================================== Files 368 396 +28 Lines 26603 28471 +1868 Branches 1447 1464 +17 ========================================== + Hits 22637 24375 +1738 - Misses 3658 3786 +128 - Partials 308 310 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.