search

supamii / ah-swagger-plugin

Generate Swagger-UI documentation from Actionhero
https://www.npmjs.com/package/ah-swagger-plugin
MIT License
17 stars 11 forks source link

Update project for ActionHero v18 #27

Open evantahler opened 7 years ago

evantahler commented 7 years ago

This package will no longer work with ActionHero v18+ https://github.com/actionhero/actionhero/releases/tag/18.0.0-beta.2

stylder commented 6 years ago

Yes evantahler it would be amazing

nerdoza commented 6 years ago

@supamii, are you open to PRs for an AH 18 upgrade?

m-yazdani commented 6 years ago

hi everybody, how can we link ah-swagger-plugin with actionhero version 18 ?

nerdoza commented 6 years ago

Well, since this repository seems to be abandoned, you can use my branch in the meantime. (https://github.com/bayssmekanique/ah-swagger-plugin/tree/ah-18-migration)

You would add "ah-swagger-plugin": "git+https://github.com/bayssmekanique/ah-swagger-plugin.git#ah-18-migration", to your packages.json. Please note, however, that I do not guarantee that I'll continue to support this branch in the future. I'm not sure if there is a procedure for transferring ownership of abandoned repos, but we should probably look at making a new repo for this.

waldoibarra commented 6 years ago

There is! I just sent an email, see what happens. On NPM: https://www.npmjs.com/policies/disputes On GitHub: I guess just create a new one with same name? (#26)

waldoibarra commented 6 years ago

For anyone who gets here, I got response from NPM and now I'm owner of the package, so I forked the repository here https://github.com/walbertoibarra/ah-swagger-plugin and published a new version to NPM with @bayssmekanique changes, so all new issues and PRs should be made on that fork.

supamii commented 6 years ago

I'm trying to reset my pw to npm and i'll happily hand off and add admins as needed.

supamii commented 6 years ago

Whoops, just caught up on email. Looks like @walbertoibarra has everything in order! Thank you sir!

supamii commented 6 years ago

And let me know if there's anything else I should do to make this eas(ier) on you (if possible)

waldoibarra commented 6 years ago

You're back! Hope everything is going well for you. If you want I can just give ownership back to you on NPM, so we can keep everything on this repo and if you need help maybe you can add me as a collaborator. Or maybe if you don't have that much time you could transfer the repo to me? It's really up to you. 😄

supamii commented 6 years ago

@walbertoibarra - Oh yeah, I see that you're the collaborator currently for the NPM package and that's fine by me! I would really hate to see the plugin continue to ROT - and I'm happy that you guys have taken the initiative.

waldoibarra commented 6 years ago

@supamii how about unifying the npm package and this github repo back again? What do you propose?

supamii commented 6 years ago

Sounds good!  Sorry for the delay... Found this in my spam folder

On Fri, Jun 1, 2018 at 13:42, Walberto Ibarranotifications@github.com wrote:
@supamii how about unifying the npm package and this github repo back again? What do you propose?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.