supasate / connected-react-router

A Redux binding for React Router v4
MIT License
4.73k stars 593 forks source link

Add type dependencies #327

Open OliverJAsh opened 5 years ago

OliverJAsh commented 5 years ago

The TypeScript types depend on

… yet these are listed as devDependencies, not dependencies, meaning the user will have to manually and carefully install the correct dependency versions themselves.

https://github.com/supasate/connected-react-router/blob/aef9998487fd2750e2c229e431bfe032ec328b26/index.d.ts#L2-L12

For this reason I believe these dependencies should be added to dependencies or peerDependencies.

That seems to be the recommendation here:

supasate commented 5 years ago

@OliverJAsh, would you mind sending a PR?