Open OliverJAsh opened 5 years ago
The TypeScript types depend on
@types/react
@types/react-redux
@types/react-router
@types/history
… yet these are listed as devDependencies, not dependencies, meaning the user will have to manually and carefully install the correct dependency versions themselves.
devDependencies
dependencies
https://github.com/supasate/connected-react-router/blob/aef9998487fd2750e2c229e431bfe032ec328b26/index.d.ts#L2-L12
For this reason I believe these dependencies should be added to dependencies or peerDependencies.
peerDependencies
That seems to be the recommendation here:
@OliverJAsh, would you mind sending a PR?
The TypeScript types depend on
@types/react
@types/react-redux
@types/react-router
@types/history
… yet these are listed as
devDependencies
, notdependencies
, meaning the user will have to manually and carefully install the correct dependency versions themselves.https://github.com/supasate/connected-react-router/blob/aef9998487fd2750e2c229e431bfe032ec328b26/index.d.ts#L2-L12
For this reason I believe these dependencies should be added to
dependencies
orpeerDependencies
.That seems to be the recommendation here: