supasate / connected-react-router

A Redux binding for React Router v4
MIT License
4.73k stars 593 forks source link

Cannot find module: 'lodash.isequalwith'. #480

Closed tykdn closed 3 years ago

tykdn commented 3 years ago

When run npm install ,Failed to compile.

./node_modules/connected-react-router/esm/ConnectedRouter.js Cannot find module: 'lodash.isequalwith'. Make sure this package is installed.

connected-react-router version is 6.9.0.

image

Module lodash.isequal should be in dependencies rathe than devDependencies?

yolo2013 commented 3 years ago

+1

Ivocin commented 3 years ago

Same with you, now lodash.isequalwith is in devDependencies and peerDependencies. I think a lot users will come across this error today. You can add it as dependencies in your package.json as a temporary solution.

ltnscp9028 commented 3 years ago

I made a PR and passed the test. Hopefully it will be merged soon.

blinkcat commented 3 years ago

May be a disaster

ltnscp9028 commented 3 years ago

May be a disaster

I think so. The relevant PR must be merged urgently. Errors may occur in the production environment.

liorbentov commented 3 years ago

Same with you, now lodash.isequalwith is in devDependencies and peerDependencies. I think a lot users will come across this error today. You can add it as dependencies in your package.json as a temporary solution.

Yeap.. Already came across this one... For now, I have set the version to be a fixed version(6.8.0) 🤷

ssanri commented 3 years ago

somebody just ruined monday...

swapna-purohit-mpf commented 3 years ago

please can the fix be merged soon? we are blocked with this.

sachin-agarwal-by commented 3 years ago

can we merged this urgently as we have already upgraded to latest version and build is failing.

jebrii commented 3 years ago

For now, you can work around this by adding the lodash.isequalwith module to your list of dependencies, or you can change the dependency entry in your package.json to "connected-react-router": "6.8.0" (notice there's no ^ carrot in the version)

supasate commented 3 years ago

Should be fixed in v6.9.1.

danielweck commented 3 years ago

Thanks :)

    ERROR in ./node_modules/connected-react-router/esm/ConnectedRouter.js
    Module not found: Error: Can't resolve 'lodash.isequalwith' in 'node_modules/connected-react-router/esm'
     @ ./node_modules/connected-react-router/esm/ConnectedRouter.js 29:0-45 82:192-203
     @ ./node_modules/connected-react-router/esm/index.js
LennyLip commented 3 years ago

Should be fixed in v6.9.1.

@supasate I've got this issue with the last versions lodash and connected-react router

image

ps. "name": "lodash.isequalwith", "version": "4.4.0",

update. Ok, it seems this is rollup named expost issue.

allengordon011 commented 3 years ago

I am still getting an error from this dependency when attempting to install connected-react-router v6.9.1


npm ERR! code E404
npm ERR! 404 Not Found - GET https://<private npm registry>/lodash.isequalwith - no such package available
npm ERR! 404 
npm ERR! 404  'lodash.isequalwith@^4.4.0' is not in the npm registry.
npm ERR! 404 You should bug the author to publish it (or use the name yourself!)
npm ERR! 404 It was specified as a dependency of 'connected-react-router'
vicodinvic1 commented 1 year ago

Should be fixed in v6.9.1.

@supasate I've got this issue with the last versions lodash and connected-react router

image

ps. "name": "lodash.isequalwith", "version": "4.4.0",

update. Ok, it seems this is rollup named expost issue.

Hey, did you resolve the issue? You said it is rollup fault, I'm trying to build a prod build with Vite (it uses rollup under the hood) and it fails with mentioned error

LennyLip commented 1 year ago

Hey, did you resolve the issue? You said it is rollup fault, I'm trying to build a prod build with Vite (it uses rollup under the hood) and it fails with mentioned error

https://stackoverflow.com/a/45535902/1271271

vicodinvic1 commented 1 year ago

Hey, did you resolve the issue? You said it is rollup fault, I'm trying to build a prod build with Vite (it uses rollup under the hood) and it fails with mentioned error

https://stackoverflow.com/a/45535902/1271271

I already use @rollup/plugin-commonjs plugin and it doesn't resolve the issue

LennyLip commented 1 year ago

I already use @rollup/plugin-commonjs plugin and it doesn't resolve the issue

Do you include lodash?