search

supasate / connected-react-router

A Redux binding for React Router v4
MIT License
4.73k stars 592 forks source link

Github subtitle is misleading #522

Open JamesGelok opened 3 years ago

JamesGelok commented 3 years ago

The sidebar says: "A Redux binding for React Router v4"

Would it be better to remove the version from this subtitle? Or change it to "A Redux binding for React Router v4 and v5"

Screen Shot 2021-07-03 at 6 19 26 PM screenshot of subtitle

sarmad-ajmal commented 2 years ago

It doesn't support React Router v6, so I find the subtitle is quite precise.

JamesGelok commented 2 years ago

@sarmad-ajmal I never mentioned v6. In fact, this issue was made before v6 was even released.

It supports v5 though, but the subtitle might imply it only supports v4.