search

supasate / connected-react-router

A Redux binding for React Router v4
MIT License
4.73k stars 592 forks source link

BrowserHistoryOptions does not contain base name #524

Open gregryork opened 3 years ago

gregryork commented 3 years ago

The example given in the FAQ for configuring the router does not work as base name is not part of BrowserHistoryOptions. This used to work in older versions of connected-react-router, as I copied this line from a project from a few months ago.

export const history = createBrowserHistory({ basename: process.env.PUBLIC_URL, });

gregryork commented 3 years ago

Looks like it's been removed in "history", so the correct code is now

export const history = createBrowserHistory();