supasate / connected-react-router

A Redux binding for React Router v4
MIT License
4.73k stars 593 forks source link

add children to typings to support removal of same in react 18 typings #569

Closed aesser closed 2 years ago

aesser commented 2 years ago

Current typing definition will cause the following error when upgrading to React 18 typing definitions Property 'children' does not exist on type 'IntrinsicAttributes & IntrinsicClassAttributes ...

This PR adds the children prop.

Ref: https://github.com/supasate/connected-react-router/issues/565

See also SO answer as reference: https://stackoverflow.com/questions/71788254/react-18-typescript-children-fc/71809927#71809927