supasate / connected-react-router

A Redux binding for React Router v4
MIT License
4.73k stars 593 forks source link

When will the support come for react@18? #616

Open silvanoamaral opened 6 months ago

gkamesh98 commented 6 months ago

I think currently they don't provide support in near future. If you still want to use it with react-router@v6. You can make small tweak as follows. Instead of using the ConnectedRouter You can make following default react-router Router component and make changes as follows

import React, { useLayoutEffect, useRef, useState } from 'react'
import { Route, Router, Routes } from 'react-router-dom'

import { createBrowserHistory } from 'history'
import { useDispatch } from 'react-redux'
import { onLocationChanged } from 'connected-react-router'

const history = createBrowserHistory()

export default ({ children }) => {
  const isFirstRender = useRef(true)
  const dispatch = useDispatch()
  const [historyState, setHistoryState] = useState({
    action: history.action,
    location: history.location,
  })

  useLayoutEffect(() => {
    return history.listen(setHistoryState)
  }, [])

  useLayoutEffect(() => {
    if (isFirstRender.current) {
      dispatch(onLocationChanged(history.location, history.action, true))
      isFirstRender.current = false
    }
    return history.listen((arg) => {
      dispatch(onLocationChanged(arg.location, arg.action, false))
    })
  }, [dispatch])

  return (
    <Router
      // ...rest of props required
      location={historyState.location}
      action={historyState.action}
      navigator={history}
    >
      {/* here it lies <Routes> <Route> ..... */}
      {children}
    </Router>
  )
}

Rest of it is same as before. I hope it is helpful. Thank you.

silvanoamaral commented 6 months ago

Hi @gkamesh98 Thank you for your help.

But, I tried to execute the suggestion and presented the error below.

ERROR in ./node_modules/connected-react-router/esm/ConnectedRouter.js 113:0-38 Module not found: Error: Can't resolve 'react-router'

pierroberto commented 5 months ago

Is there any other alternative?

gkamesh98 commented 5 months ago

Hi @silvanoamaral , Can you check is react-router package is installed because connected-react-router has react-router as peerDependency.

Basically if you have react-router-dom it will install react-router as well if you check in package-lock.json or yarn.lock.

gkamesh98 commented 5 months ago

Hi @pierroberto , As react-router routing api is updated. So, we need to get the package update. Or we will have to move to alternative package. But redux actions are also update as a part of it. If you are thinking of update. If you thinking fresh update. You can go for the complete different package for integrating redux and router-router. One of it could be "redux-first-history"