search

super-continent / bbscript

Parses BBScript for various Arc System Works Games
GNU General Public License v3.0
42 stars 11 forks source link

Parsing DNF files #26

Closed AshSuqs closed 1 year ago

AshSuqs commented 1 year ago

Currently trying to parse the bbscript files and the current version says it supports DNF but every attempt just returns the error "ERROR: Config contains multiple instances of an instruction named addObjectSize" I am attempting this specifically with extracted "RED\Content\Chara\03A\Common\Data\BBS_03A" Not sure if this is an issue with the patch that went through a couple months back or if it is a fault of my own somehow.

AshSuqs commented 1 year ago

Okay so it wasn't an issue of the game getting an update in that time or my own, the "dnf.ron" file is just faulty. The file has a duplicate command at 388 that is "addObjectSize" when it should be "objectSizePercent". An easy fix but I feel it should have at least been tested before doing a release.

super-continent commented 1 year ago

these were tested unfortunately its easy for issues like this to slip through the cracks, i don't remember who original authored the dnf.ron file but it was probably before this issue was automatically detected and reported by bbscript. will try to work on fixing the config, not sure why there are 2 duplicate names here

super-continent commented 1 year ago

alright, mentioned this issue to @WistfulHopes (who authored this config file, and confirmed it was before i introduced all the config sanity checks), we should have this closed as soon as the new config is uploaded

super-continent commented 1 year ago

fixed by #27, not out on release yet but should work through downloading newest configs from master branch