search

super-linter / super-linter

Combination of multiple linters to run as a GitHub Action or standalone
https://github.com/super-linter/super-linter
MIT License
9.53k stars 973 forks source link

Automatic code review in pull requests #178

Closed plata closed 4 years ago

plata commented 4 years ago

Is your feature request related to a problem? Please describe. From my current understanding, the super linter results are reported only in the action result. The visibility could be better.

Describe the solution you'd like Create a code review (e.g. like reviewdog).

Describe alternatives you've considered Using reviewdog actions directly.

hyjkim commented 4 years ago

Some useful references to implement this feature:

https://developer.github.com/v3/checks/runs/#annotations-object-1 https://github.com/actions/toolkit/blob/master/docs/commands.md#problem-matchers https://github.com/actions/toolkit/blob/master/docs/problem-matchers.md

GaboFDC commented 4 years ago

I think this is duplicated of https://github.com/github/super-linter/issues/151

plata commented 4 years ago

It's quite similar, yes. I will leave the decision if it should be tracked in one issue to the devs, though. If yes, feel free to close this.

IAmHughes commented 4 years ago

I'll let @admiralAwkbar make the final decision, but I'm comfortable closing this in favor of #151. Checks UI would help raise awareness outside of an action run workflow log, and maybe in the future we can look into implementing automatic PR suggestions (though that could be quite a bit more complex).

zkoppert commented 4 years ago

Closing and tracking in #151. Feel free to put any suggestions in there. Thanks all!