search

super-linter / super-linter

Combination of multiple linters to run as a GitHub Action or standalone
https://github.com/super-linter/super-linter
MIT License
9.41k stars 960 forks source link

Editorconfig linting - Stronger file filter ? #600

Closed siwon closed 4 years ago

siwon commented 4 years ago

Hi,

I hope I understood correctly the code but it seems that editorconfig linting filter is very light. It looks like it takes all the files "^.*$": https://github.com/github/super-linter/blob/0e075ccba96327a6d5dec6cc264ad7c06862e352/lib/linter.sh#L1450

Shouldn't it look like that : .*\(editorconfig\)\$?

PS: Thanks a lot for this repo :+1:

Edit: I tried to add a quick fix for this issue if it's relevent to you (#601 )

ferrarimarco commented 4 years ago

Editorconfig-checker doesn't lint the .editorconfig file (only). It checks the given file list (produced by the ^.*$ regex) against the rules specified in .editorconfig.

I guess this, and the related PR should be closed :)

siwon commented 4 years ago

Ok ! My bad ;)