Closed jplanckeel-ep closed 1 month ago
ferrarimarco
commented
2 months ago Hi! This is not about Goreleaser. It just happens to be the last linters that emits its version information, but has nothing to do with the issue you're facing.
The issue is that Git is not able to trace back the root (initial) commit starting from the 2592f4c4edfcfe1e1f9010b82cc0316bbb6f8081 commit in your repository. This command failed on your repository:
ferrarimarco
commented
2 months ago I think what's likely happening here depends on how you're checking out the repository in the Checkout code step.
This is probably a configuration issue, rather than a Super-linter issue.
ferrarimarco
commented
2 months ago I think the change that is impacting you is #5534, which landed in v6.4.1, so it matches with your statement about versions < v6.4 working fine.
@jplanckeel-ep In order to understand what's happening here, we need to reproduce the issue first. Can you please provide a link to a workflow with debug logging enabled if this is a public repository? If it's a private repository, we need more help from your side to try to reproduce the issue, so we probably need that that you collect the logs yourself, taking care of redacting private information. We probably need both the actions/checkout log, and the super-linter debug log.
ferrarimarco
commented
1 month ago No replies. Closing this. We can reopen later if we get more data points. Thanks for taking the time to file this issue in the first place!
nartb
commented
1 month ago I've also run into the issue described here by @jplanckeel-ep.
I'm currently on v6.4.0 and have had multiple dependabot PRs trying to upgrade super-linter from that version fail with the same output given above.
The commit SHA for "Successfully found GITHUB_SHA" and a "fatal: bad object" seems to be the merge commit resulting from merging the dependabot update commit to the original branch's head.
I definitely might be missing an obvious issue with what I'm doing but I'm not very well versed in this side of things so nothing is sticking out to me.
I also have pretty much the exact same way of checking out code as @jplanckeel-ep so that's definitely a likely culprit.
This is my workflow step for checking out the code:
- name: Checkout code
uses: actions/checkout@v4
with:
# Full git history is needed to get a proper list of changed files within `super-linter`
fetch-depth: 0
# Checkout the code from the pull request instead of the merge commit
ref: ${{ github.event.pull_request.head.sha }}This is my configuration for super-linter:
- name: Run super-linter
uses: super-linter/super-linter/slim@v6.4.0
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
# Only run on changed files
VALIDATE_ALL_CODEBASE: false
LINTER_RULES_PATH: .
LOG_LEVEL: INFO
JAVASCRIPT_DEFAULT_STYLE: prettier
JAVASCRIPT_ES_CONFIG_FILE: .eslintrc.json
TYPESCRIPT_DEFAULT_STYLE: prettier
TYPESCRIPT_ES_CONFIG_FILE: .eslintrc.json
# Explicitly state filetypes to validate (those not included will not be linted)
VALIDATE_BASH: true
VALIDATE_DOCKERFILE_HADOLINT: true
VALIDATE_GITHUB_ACTIONS: true
VALIDATE_GITLEAKS: true
VALIDATE_HTML: true
VALIDATE_JAVASCRIPT_ES: true
VALIDATE_JSX: true
VALIDATE_TSX: true
VALIDATE_TYPESCRIPT_ES: true
VALIDATE_YAML: trueI'll also try to provide the debug log if I can't figure it out.
Is there an existing issue for this?
Are you using the latest Super-linter version available?
[X] I am using the latest Super-linter version.
[X] I can reproduce the issue running Super-linter using complete version identifier (example: vX.Y.Z), and not just with a partial one (example: vX)
[X] I am using the super-linter/super-linter action or container image, and not the deprecated github/super-linter action or container image.
Are you resonably sure that it's a Super-linter issue, and not an issue related to a tool that Super-linter runs?
Current Behavior
When we upgrade Super-linter with a version > 6.4 with goreleaser the action failed
We have test to disable Goreleaser with env var
VALIDATE_GO_RELEASER: false
Expected Behavior
Pipeline failed whit goreleaser.
Super-Linter version
Super-linter configuration
Relevant log output
Steps To Reproduce
Add config in workflow with v7
Anything else?
No response