Closed Uni-boy closed 8 months ago
@Uni-boy is your PR ready for review please?
Yeah my PR is ready.
@Uni-boy if you don't have any plan to update this PR, please feel free to close it. Thank you.
I finalized the model and all tests passed.
I finalized the model and all tests passed.
Please merge from master
and resolve conflicts.
More importantly, when I said "these structs should be consumed", I meant the structs
you created should replace codes like let strings = json["strings"] as? [String: Any]
in main.swift
. What do you think the codebase can benefit from some data models that are not used anywhere?
I finalized the model and all tests passed.
Please merge from
master
and resolve conflicts.More importantly, when I said "these structs should be consumed", I meant the
structs
you created should replace codes likelet strings = json["strings"] as? [String: Any]
inmain.swift
. What do you think the codebase can benefit from some data models that are not used anywhere?
I applied the model to main.swift and solved the TODO in StringEnumHelper.swift