search

superawesomeme / moodle-theme_aardvark

Aardvark theme for Moodle
https://moodle.org/plugins/view.php?plugin=theme_aardvark
6 stars 14 forks source link

Nested Drop-downs don't open on mobile view #5

Open gazlee opened 8 years ago

gazlee commented 8 years ago

Nested drop downs don't seem to open on mobile devices. Tested with Moodle 2.9.1+ and iOS/Android.

tqtecnol commented 8 years ago

In moodle 3.0 + Android nested drop downs don't open too. Some idea to fix it?

rimas-kudelis commented 8 years ago

@superawesomeme according to https://moodle.org/plugins/view.php?plugin=theme_aardvark, you have fixed this already. How often do you push updates to GitHub? Is it a bad idea to check out this theme from git as a submodule instead of downloading it from the web?

superawesomeme commented 8 years ago

Github should be up-to-date

On 6 Sep 2016 18:49, "Rimas Kudelis" notifications@github.com wrote:

@superawesomeme https://github.com/superawesomeme according to https://moodle.org/plugins/view.php?plugin=theme_aardvark, you have fixed this already. How often do you push updates to GitHub? Is it a bad idea to check out this theme from git as a submodule instead of downloading it from the web?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/superawesomeme/moodle-theme_aardvark/issues/5#issuecomment-245027805, or mute the thread https://github.com/notifications/unsubscribe-auth/AA6D91l9a9WLL-FqeHUhSBQXNW5GTERGks5qnaRTgaJpZM4HBK0J .

rimas-kudelis commented 8 years ago

Github should be up-to-date

It's not. The plugin page has version 2016081900, meanwhile in GitHub, the last one is 2016081800. You must have forgotten to push this latest change.

superawesomeme commented 8 years ago

Sorry. We can't use GitHub on the PCs here so I have to switch between my PC and Mac which means I often miss updates. I've updated it now.

rimas-kudelis commented 8 years ago

@superawesomeme sorry to bother you, but you forgot to push that changeset into the branches...

superawesomeme commented 8 years ago

Sorry should be pushed through now

On 7 Sep 2016 9:59 a.m., "Rimas Kudelis" notifications@github.com wrote:

@superawesomeme https://github.com/superawesomeme sorry to bother you, but you forgot to push that changeset to branches...

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/superawesomeme/moodle-theme_aardvark/issues/5#issuecomment-245218942, or mute the thread https://github.com/notifications/unsubscribe-auth/AA6D956l2iBJKB1AnunqZ-PjKuw-9PYIks5qnnzegaJpZM4HBK0J .

rimas-kudelis commented 8 years ago

thank you!

rimas-kudelis commented 8 years ago

By the way, I believe this (original) bug has been fixed too. Just tested this on iPad and in responsive design mode on my Firefox, and nested menus work fine for me.