search

superbit-collaboration / superbit-metacal

Contains a collection of routines used to perform gmix/metacalibration on simulated SuperBIT images
4 stars 0 forks source link

Ngmixv2 version #141

Open GeorgeVassilakis opened 3 months ago

GeorgeVassilakis commented 3 months ago

Creating a pull request just to compare the version of metacalibration in the ngmixv2 branch versus process-real branch. Theoretically, the ngmixv2 branch was a complete working pipeline with ngmix v2.0.0 but was merged into master and got forgotten about (@sweverett can you confirm this?). If so, we want to integrate ngmixv2 into the new pipeline.

sweverett commented 3 months ago

Hello! It's been ages, but here's my memory of the situation:

  1. I made the ngmixv2 branch to provide classes & utilities to interface with more modern versions of ngmix that had API-breaking changes (hence the v2.X bit)
  2. I tested the classes and had a working version that ran the newer ngmix. As they had different dependencies, we had two separate conda env files
  3. @mcclearyj and my work bifurcated at some point where she focused on finishing the lensing in the blue paper (w/ ngmix v1.X I believe) while I built OBA. At that time I stopped focusing on any compatibility with the existing repo
  4. I went on leave and never touched this again. I have no memory of whether the branch was ever merged into main

Hopefully that helps!

GeorgeVassilakis commented 3 months ago

Great, thank you for that update, Spencer! That is really helpful. We weren't sure whether the ngmixv2 branch was an operational version or not (at the time of your last commit), so thank you for confirming that it worked when you worked on it. I plan on trying to pull the pieces together of this ngmixv2 branch and get this merged into our process-real branch, which is what we've been working on for the last 1+ year. Appreciate the help!

sweverett commented 3 months ago

Good luck! Feel free to ask any questions that you run into

GeorgeVassilakis commented 3 months ago

Thanks, will do.