search

supercharge / mongodb-github-action

Use MongoDB in GitHub Actions
MIT License
222 stars 46 forks source link

Fix support to MongoDB 4.x, 5.0 and 6.0 #35

Closed ecarruda closed 2 years ago

ecarruda commented 2 years ago

Closes #34

marcuspoehls commented 2 years ago

@ecarruda Hey Evandro, thank you for the merge request! I really appreciate your work. The tests are failing for MongoDB 4.x because the tests try to use mongosh instead of mongo. I can’t see the issue right now. Do you have an idea?

ecarruda commented 2 years ago

Fixed wildcard problem sh vs bash, it worked locally on my MacOS even using sh so I didn't pay attention on the interpreter definition of the script, sorry for this mess, fixed using shell script built in commands. Waiting my local tests but I did some tests on linux and test workflow and all good. :)

marcuspoehls commented 2 years ago

Awesome! Thank you for the refinements! 👍

ecarruda commented 2 years ago

Awesome! Thank you for the refinements! 👍

Thank you guys for the opportunity to contribute with this amazing actions solution to MongoDB on Github

ecarruda commented 2 years ago

@marcuspoehls all good now :) I just requested your review again and I also appreciate @idorrington92 review too :) Thank you guys. If you need some change or dislike the approach let me know.

idorrington92 commented 2 years ago

That was a subtle bug! Thanks for fixing this so quickly @ecarruda

marcuspoehls commented 2 years ago

@ecarruda Just left a minor comment. Looks good overall. I’m happy to merge it. Will just wait in case you have an opinion related to my comment :)

ecarruda commented 2 years ago

@ecarruda Just left a minor comment. Looks good overall. I’m happy to merge it. Will just wait in case you have an opinion related to my comment :)

Yes, thanks. I'm always accept syntax improvements suggestion, I checked on cut man pages definitions and tested it here before and all good. Sent the change :) Thank you! Requested you review again

marcuspoehls commented 2 years ago

@ecarruda Great 😃 I’ll merge this PR as soon as the test pipeline finishes

ecarruda commented 2 years ago

@ecarruda Great 😃 I’ll merge this PR as soon as the test pipeline finishes

Pretty good!!! Let me ask you, do you have any ideia/roadmap about when you will have another release with this change?

marcuspoehls commented 2 years ago

New release comes in 10 minutes

marcuspoehls commented 2 years ago

I’ve published version 1.8.0 to the GitHub Marketplace

ecarruda commented 2 years ago

I’ve published version 1.8.0 to the GitHub Marketplace

Thank you starting to update my workflows here to test it :)

marcuspoehls commented 2 years ago

Cool! Please let me know how it works :)

ecarruda commented 2 years ago

I’ve published version 1.8.0 to the GitHub Marketplace

@marcuspoehls just one thing strange, before i was using as your documentation but for some reason market is saying to use with v prefix now

- name: MongoDB in GitHub Actions
  uses: supercharge/mongodb-github-action@v1.8.0

Maybe how you did the release?!? I am going to test like this, because with only @1.8.0 it fails

ecarruda commented 2 years ago

All working good here @marcuspoehls just this problem with the version tag, just let me know if you are going to do any change to rollback to 1.8.0 instead of v1.8.0 then I decide my move here, if you are going to let with the v prefix some update on market documentation is also needed.

marcuspoehls commented 2 years ago

@ecarruda Thank you for pointing this out! I’ve deleted the tag with the v prefix. And tagged a new version (including release) using just 1.8.0.