Closed Kolrolf closed 8 years ago
It's because Galacticraft instantiates their biomes when their biome classes load. This leads to unpredictable load times, so I resorted to loading them manually at preInit
Unfortunately, the config hasn't been loaded by this time, so the biomes are created with incorrect IDs. I'll fix this by telling Forge to load BT after GC, but it would be nice if GC had a system to allow for predictable register times for their biomes. @radfast
http://jenkins.superckl.me/job/BiomeTweaker/182/
Let me know if it works. I said I'd stop updating the 1.7.10 branch, but I did for you ;)
Official beta version: http://minecraft.curseforge.com/projects/biometweaker/files/2279911
I just tested it with a new world and it checks out, Galacticraft biomes in their adjusted IDs. This is great, thanks for opening the branch up for this issue! Thanks so much!
Hey @superckl
We can initialise biomes at a fixed time. Do you think it's better in preinit or init phase? When do most mods do it? Seems like preinit may be best now.
See also: https://github.com/MinecraftForge/MinecraftForge/issues/1704 I think you will be interested.
Biomes O Plenty and ExtraBiomesXL both do it during preInit:
I would recommend that.
It seems that the branch provided above now causes a crash on startup is there an updated version with GC that still works?
I'm going to need your crash report. If it's below version 1.8.9, I'm not going to address it. Those versions are no longer under development.
This is from 1.2.128, the latest dev one listed on curse and the one linked above.
`---- Minecraft Crash Report ---- // Surprise! Haha. Well, this is awkward.
Time: 8/23/16 11:21 AM Description: Initializing game
java.lang.NoSuchFieldError: biomeID at me.superckl.biometweaker.common.handler.BiomeEventHandler.onCreateBiomeDecorator(BiomeEventHandler.java:251) at cpw.mods.fml.common.eventhandler.ASMEventHandler_272_BiomeEventHandler_onCreateBiomeDecorator_CreateDecorator.invoke(.dynamic) at cpw.mods.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:54) at cpw.mods.fml.common.eventhandler.EventBus.post(EventBus.java:140) at net.minecraftforge.event.terraingen.DeferredBiomeDecorator.fireCreateEventAndReplace(DeferredBiomeDecorator.java:43) at net.minecraftforge.common.BiomeDictionary.registerAllBiomesAndGenerateEvents(BiomeDictionary.java:300) at net.minecraftforge.common.ForgeModContainer.postInit(ForgeModContainer.java:290) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) at java.lang.reflect.Method.invoke(Unknown Source) at com.google.common.eventbus.EventSubscriber.handleEvent(EventSubscriber.java:74) at com.google.common.eventbus.SynchronizedEventSubscriber.handleEvent(SynchronizedEventSubscriber.java:47) at com.google.common.eventbus.EventBus.dispatch(EventBus.java:322) at com.google.common.eventbus.EventBus.dispatchQueuedEvents(EventBus.java:304) at com.google.common.eventbus.EventBus.post(EventBus.java:275) at cpw.mods.fml.common.LoadController.sendEventToModContainer(LoadController.java:212) at cpw.mods.fml.common.LoadController.propogateStateMessage(LoadController.java:190) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) at java.lang.reflect.Method.invoke(Unknown Source) at com.google.common.eventbus.EventSubscriber.handleEvent(EventSubscriber.java:74) at com.google.common.eventbus.SynchronizedEventSubscriber.handleEvent(SynchronizedEventSubscriber.java:47) at com.google.common.eventbus.EventBus.dispatch(EventBus.java:322) at com.google.common.eventbus.EventBus.dispatchQueuedEvents(EventBus.java:304) at com.google.common.eventbus.EventBus.post(EventBus.java:275) at cpw.mods.fml.common.LoadController.distributeStateMessage(LoadController.java:119) at cpw.mods.fml.common.Loader.initializeMods(Loader.java:742) at cpw.mods.fml.client.FMLClientHandler.finishMinecraftLoading(FMLClientHandler.java:311) at net.minecraft.client.Minecraft.func_71384_a(Minecraft.java:552) at net.minecraft.client.Minecraft.func_99999_d(Minecraft.java:878) at net.minecraft.client.main.Main.main(SourceFile:148) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) at java.lang.reflect.Method.invoke(Unknown Source) at net.minecraft.launchwrapper.Launch.launch(Launch.java:135) at net.minecraft.launchwrapper.Launch.main(Launch.java:28) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) at java.lang.reflect.Method.invoke(Unknown Source) at org.multimc.onesix.OneSixLauncher.launchWithMainClass(OneSixLauncher.java:310) at org.multimc.onesix.OneSixLauncher.launch(OneSixLauncher.java:395) at org.multimc.EntryPoint.listen(EntryPoint.java:170) at org.multimc.EntryPoint.main(EntryPoint.java:54)
-- Head -- Stacktrace: at me.superckl.biometweaker.common.handler.BiomeEventHandler.onCreateBiomeDecorator(BiomeEventHandler.java:251) at cpw.mods.fml.common.eventhandler.ASMEventHandler_272_BiomeEventHandler_onCreateBiomeDecorator_CreateDecorator.invoke(.dynamic) at cpw.mods.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:54) at cpw.mods.fml.common.eventhandler.EventBus.post(EventBus.java:140) at net.minecraftforge.event.terraingen.DeferredBiomeDecorator.fireCreateEventAndReplace(DeferredBiomeDecorator.java:43) at net.minecraftforge.common.BiomeDictionary.registerAllBiomesAndGenerateEvents(BiomeDictionary.java:300) at net.minecraftforge.common.ForgeModContainer.postInit(ForgeModContainer.java:290) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) at java.lang.reflect.Method.invoke(Unknown Source) at com.google.common.eventbus.EventSubscriber.handleEvent(EventSubscriber.java:74) at com.google.common.eventbus.SynchronizedEventSubscriber.handleEvent(SynchronizedEventSubscriber.java:47) at com.google.common.eventbus.EventBus.dispatch(EventBus.java:322) at com.google.common.eventbus.EventBus.dispatchQueuedEvents(EventBus.java:304) at com.google.common.eventbus.EventBus.post(EventBus.java:275) at cpw.mods.fml.common.LoadController.sendEventToModContainer(LoadController.java:212) at cpw.mods.fml.common.LoadController.propogateStateMessage(LoadController.java:190) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) at java.lang.reflect.Method.invoke(Unknown Source) at com.google.common.eventbus.EventSubscriber.handleEvent(EventSubscriber.java:74) at com.google.common.eventbus.SynchronizedEventSubscriber.handleEvent(SynchronizedEventSubscriber.java:47) at com.google.common.eventbus.EventBus.dispatch(EventBus.java:322) at com.google.common.eventbus.EventBus.dispatchQueuedEvents(EventBus.java:304) at com.google.common.eventbus.EventBus.post(EventBus.java:275) at cpw.mods.fml.common.LoadController.distributeStateMessage(LoadController.java:119) at cpw.mods.fml.common.Loader.initializeMods(Loader.java:742) at cpw.mods.fml.client.FMLClientHandler.finishMinecraftLoading(FMLClientHandler.java:311) at net.minecraft.client.Minecraft.func_71384_a(Minecraft.java:552) at net.minecraft.client.Minecraft.func_99999_d(Minecraft.java:878)
-- Initialization -- Details: Stacktrace: at net.minecraft.client.main.Main.main(SourceFile:148) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) at java.lang.reflect.Method.invoke(Unknown Source) at net.minecraft.launchwrapper.Launch.launch(Launch.java:135) at net.minecraft.launchwrapper.Launch.main(Launch.java:28) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) at java.lang.reflect.Method.invoke(Unknown Source) at org.multimc.onesix.OneSixLauncher.launchWithMainClass(OneSixLauncher.java:310) at org.multimc.onesix.OneSixLauncher.launch(OneSixLauncher.java:395) at org.multimc.EntryPoint.listen(EntryPoint.java:170) at org.multimc.EntryPoint.main(EntryPoint.java:54)
-- System Details --
Details:
Minecraft Version: 1.7.10
Operating System: Windows 10 (amd64) version 10.0
Java Version: 1.8.0_101, Oracle Corporation
Java VM Version: Java HotSpot(TM) 64-Bit Server VM (mixed mode), Oracle Corporation
Memory: 1055094576 bytes (1006 MB) / 4506255360 bytes (4297 MB) up to 7516192768 bytes (7168 MB)
JVM Flags: 3 total; -XX:HeapDumpPath=MojangTricksIntelDriversForPerformance_javaw.exe_minecraft.exe.heapdump -Xms512m -Xmx8064m
AABB Pool Size: 0 (0 bytes; 0 MB) allocated, 0 (0 bytes; 0 MB) used
IntCache: cache: 0, tcache: 0, allocated: 0, tallocated: 0
FML: MCP v9.05 FML v7.10.99.99 Minecraft Forge 10.13.4.1566 Optifine OptiFine_1.7.10_HD_U_D6 242 mods loaded, 237 mods active
States: 'U' = Unloaded 'L' = Loaded 'C' = Constructed 'H' = Pre-initialized 'I' = Initialized 'J' = Post-initialized 'A' = Available 'D' = Disabled 'E' = Errored
UCHIJ mcp{9.05} Minecraft Coder Pack
UCHIJ FML{7.10.99.99} Forge Mod Loader
UCHI Forge{10.13.4.1566} Minecraft Forge
UCHI appliedenergistics2-core{rv3-beta-6} Applied Energistics 2 Core
UCHI CodeChickenCore{1.0.7.47} CodeChicken Core
UCHI Micdoodlecore{} Micdoodle8 Core
UCHI NotEnoughItems{1.0.5.120} Not Enough Items
UCHI ThE-core{1.0.0.1} Thaumic Energistics Core
UCHI ThaumicTinkerer-preloader{0.1} Thaumic Tinkerer Core
UCHI WitchingGadgetsCore{1.1.10} Witching Gadgets Core
UCHI ChocoPatcher{1.1} Choco Patcher
UCHI OpenModsCore{0.9.1} OpenModsCore
UCHI
Is Modded: Definitely; Client brand changed to 'fml,forge'
Type: Client (map_client.txt)
Resource Packs: [JSTR Update.zip]
Current Language: English (US)
Profiler Position: N/A (disabled)
Vec3 Pool Size: 0 (0 bytes; 0 MB) allocated, 0 (0 bytes; 0 MB) used
Anisotropic Filtering: Off (1)
OptiFine Version: OptiFine_1.7.10_HD_U_D6
Render Distance Chunks: 16
Mipmaps: 4
Anisotropic Filtering: 1
Antialiasing: 0
Multitexture: false
OpenGlVersion: 4.5.13447 Compatibility Profile Context 16.300.2511.1001
OpenGlRenderer: AMD Radeon R7 200 Series
OpenGlVendor: ATI Technologies Inc.
CpuCount: 4`
As said, 1.7.10 is no longer supported. If this is still an issue in 1.8.9+, please open a new issue with details. Sorry. All O can suggest is playing with Forge and GC versions.
Very well, thank you for your time, sorry to necro.
@Yurigirl and anyone else who is interested:
In 1.7.10, Galacticraft versions 3.0.12.472 and later should now be able to work with the regular (not branched) 1.7.10 BiomeTweaker. We will also incorporate this into our 1.8.9 beta
Thanks to @superckl for the suggestion and sorry it took us a long time to fix it, I had to take a break from modding for many months due to real life issues, and micdoodle8 has been working only on our 1.8.9 version
GalactCoreCompat should therefore be unnecessary in future, I hope?
I've got BiomeTweaker version 1.2.128 and it's causing an issue with Galacticraft biome IDs.
I'm trying to change the biome IDs for Galacticraft in its configs but the biome IDs are not changing. Setting I:biomeIDBase=201; saving the config file; creating a new world and using NEI to dump the biome IDs I get the following: 102 moon 103 marsFlat ... 203 asteroids
The default IDs would be: 102 moon 103 marsFlat 104 asteroids and the adjusted IDs should be: 201 moon 202 marsFlat 203 asteroids
So the asteriods biome is responding to the config option correctly, but the moon and marsFlat biomes are not. I've removed BiomeTweaker from my mod list and the Galacticraft biomes move to their correct adjusted IDs. When I add BiomeTweaker back into the mix the Glacticraft biomes get messed up.
I do not have a script that is written to affect any of these biomes or biome IDs.
Using Forge version 13.4.1566
I have the following mods installed: