DisplayImage Contact Events

[GoogleCodeExporter]

A. Logging off the client and relogging the client

What steps will reproduce the problem?
1. Log into client (using MSNP MSN)
2. Log off client (make Online to Offline)
3. Log into client with the same e-mail again (w/out changing status)

What is the expected output? What do you see instead?
I expect to log in without exception but caused System.ObjectDisposedException 
exception.

Please use labels and text to provide additional information.
Just disable Offline node when MSNP client is not logged in and enable it once 
it is.

B. Logging off the client and relogging the client

What steps will reproduce the problem?
1. Create conversation, start talking
2. Display image will change
3. Change display image again from the remote contact

What is the expected output? What do you see instead?
I expect to see a change again but instead it does not (I don't know but it 
does start the transfer, but it freezes and does not continue at some point), 
and sometimes when I do it multiple times it still does not work.

It works again if I delete the MCL (address book files?) file formats in that 
folder and then load the client again.

In MSN Live however, I am able to change my display picture, and the other 
account will receive it straight away.

Please use labels and text to provide additional information.
Used comparison between MSNPSharp Client and MSN Live.

Original issue reported on code.google.com by electk...@gmail.com on 3 Jul 2010 at 7:46

[GoogleCodeExporter]

For issue B. (forgot to edit), it'll be "Display Image doesn't change in 
conversation form"

Original comment by electk...@gmail.com on 3 Jul 2010 at 7:47

[GoogleCodeExporter]

Fixed issue A (this is not a big deal).

Original comment by electk...@gmail.com on 3 Jul 2010 at 8:26

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

Starting to find out a bit more information, the image context must be this 
long piece of encoded URL, and when decoded I get this:

<msnobj Creator="electkong@hotmail.com" Type="3" 
SHA1D="P9RYtILl9x3cRSEekVGZYQwfixc=" Size="19890" Location="0" 
Friendly="YQB2AGEAdABhAHIAMwAAAA=="/>

The FireDisplayImageContextChangedEvent will be fired, but a few comments I 
will make from here:
+ The updated is not null, therefore it will follow next if condition
+ The updated image is not null, but I am guessing the SHA encryption is equal 
to the current one. I think this is the bit that is stopping it.

I'll do some more research along the way.

Original comment by electk...@gmail.com on 5 Jul 2010 at 7:28

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

Wait, I think I may have found the problem. Pang WU can you please check my 
code if I do commit another code.

Original comment by electk...@gmail.com on 5 Jul 2010 at 10:33

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

Uhh... The SHA code is the same, even though I change my display image. When I 
compare the old SHA with the new one received it is still the same.

For now I'll leave this information for the owner to decide :) .

Original comment by electk...@gmail.com on 5 Jul 2010 at 11:14

[GoogleCodeExporter]

Wait, I'll handle it. Don't want to be a pain, thus I can figure out this in 
some way.

Original comment by electk...@gmail.com on 5 Jul 2010 at 11:22

[GoogleCodeExporter]

Okay, fixed part of the problem but the display picture won't change if I 
change the display picture of the other contact, then get the test account to 
log off and log in again. It looks the same.

I'll fix this soon enough :) .

Original comment by electk...@gmail.com on 6 Jul 2010 at 5:45

• Changed state: Accepted

[GoogleCodeExporter]

Fixed part of the problem where the MCL file wouldn't save display picture, but 
now getting problem that the display picture won't trigger DisplayImageChanged 
event (but DisplayImageContextChanged event will) for the first time.

It will however the second time :/

Original comment by electk...@gmail.com on 6 Jul 2010 at 2:29

[GoogleCodeExporter]

Look at Contact.cs line 969: SetDisplayImage function. You will understand it:)

Original comment by freezing...@gmail.com on 6 Jul 2010 at 7:28

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

Original comment by electk...@gmail.com on 7 Jul 2010 at 5:18

• Changed title: DisplayImage Contact Events

[GoogleCodeExporter]

Do you mean that the local user change his display image, then he logoff and 
login again, other remote contact can't get his new display image because the 
SB transfer returns a NAK command?

Original comment by freezing...@gmail.com on 7 Jul 2010 at 5:57

[GoogleCodeExporter]

Yes, and the NAK (X) increases by 1 by each time I get the other contact to 
change his display image again.

Original comment by electk...@gmail.com on 7 Jul 2010 at 6:16

[GoogleCodeExporter]

Wait, the other contact change his display image, not the local user.

Original comment by electk...@gmail.com on 7 Jul 2010 at 6:16

[GoogleCodeExporter]

Wait, this problem now reproduces when I get the remote contact to change DP, 
make the main owner logoff and login back again.

Getting the remote contact to change his display picture again will cause a NAK.

Original comment by electk...@gmail.com on 7 Jul 2010 at 9:28

[GoogleCodeExporter]

Looks like the problems are fixed. The display image events should work 
properly now :)

Original comment by electk...@gmail.com on 7 Jul 2010 at 1:55

• Changed state: Fixed

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

Fixed by multiple revisions: r1632, r1633, r1634, r1635 and r1637 :)

Original comment by electk...@gmail.com on 7 Jul 2010 at 1:57

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

Freezingsoft covered the holes of the problem from r1643

Original comment by electk...@gmail.com on 10 Jul 2010 at 3:54

[GoogleCodeExporter]

Original comment by hepha...@gmail.com on 20 Sep 2010 at 10:38

• Added labels: Milestone-Release3.1.0