Popup to accept a deleted contact - the contact get's displayed in the contact list although is deleted

[GoogleCodeExporter]

1) Sign in with test client
2) Remove one of your contacts (check "Remove this user from my contact list")
3) It remains on the list and it's Guid is set to 0000 etc...
4) If you sign out and sign in again, the removed contact is in the list with a 
Guid of 0000 etc. In addition you'll get a popup dialog to accept the removed 
contact

- If you click on OK with the "Add this user to my contact list" checked, the 
removed contact get's a valid Guid again and is in your contact list. 
- If you click on Cancel, then you get the popup the next time you sign in. 
- If you Click on OK without accepting the removed contact (Add this user to my 
contact list is not checked) then the popup is gone the next time you sign in 
but the removed (an not accepted) contact is still in the list.

The normal would be when deleting or not accepting (by not checking "Add this 
user to my contact list is not checked" option and clicking on OK) a contact, 
the contact wouldn't be displayed in the contact list everytime you sign in. 

In addition when you remove a contact, you should not get a popup to accept it 
again the next time you sign in as you have just deleted it. This problem seems 
to be solved if in Nameserver_ReverseAdded you check only the PendingList 
property of the contact in order to raise a popup dialog to accept it.

Something I've noticed is that MSNPSharp preserves internally the contact you 
delete, but when you delete it it's Guid is set to zeros. Maybe this is a way 
to know if a contact is deleted so you don't display it in the contact list 
when signing in the next time.

I use MSNPSharp 3.1.4 running on .NET 2.0 and Windows 7 x64

Original issue reported on code.google.com by kernel...@gmail.com on 21 Apr 2011 at 8:20

[GoogleCodeExporter]

3.1 branch is obsolete and no more supported.
Please download v4.0 and try again. Is the problem still exists?

Original comment by hepha...@gmail.com on 21 Apr 2011 at 8:45

[GoogleCodeExporter]

Ethem, 
I think we still need t support 3.1 since 4.0 is not release yet. Would you 
please try to do a fix for this issue if you have time?

Original comment by freezing...@gmail.com on 21 Apr 2011 at 7:18

[GoogleCodeExporter]

I am afraid but it is wlm bug.

Previously, when you delete a contact "Remove this user from my contact list" 
and no block, allow list wasn't deleted. But now, when you delete a contact, 
wlm deletes from allow list, too. And when you logged in again, the list remain 
is "reverse" only and our client fires reverse added. To manage with this 
issue, add contact to allow or block list and it is valid for MSNP18.

I have no time fixing wlm bugs, because fixing a bug causes a new bug. And why 
we fix unsupported protocol. WLM2009 only works on XP and XP id dead.

Original comment by hepha...@gmail.com on 22 Apr 2011 at 8:33

• Changed state: WontFix

[GoogleCodeExporter]

But we had a lot of user still using 3.0 though, we should fix it since 4.0 is 
still in developing.

Original comment by freezing...@gmail.com on 22 Apr 2011 at 9:25

• Changed state: Accepted

[GoogleCodeExporter]

Original comment by freezing...@gmail.com on 22 Apr 2011 at 9:27

[GoogleCodeExporter]

If you accept to maintain the 3.x branch, no problem :)

Original comment by hepha...@gmail.com on 22 Apr 2011 at 9:57

[GoogleCodeExporter]

Hi,

I decide not to fix this bug after taking a detail look into the problem, Ethem 
is right, you can add the contact to AllowList after you delete the contact.

Original comment by freezing...@gmail.com on 12 May 2011 at 6:14

• Changed state: WontFix