supercoeus / msnp-sharp

Automatically exported from code.google.com/p/msnp-sharp
0 stars 1 forks source link

Changing Personal Message with provisional Account produce a disconnection #275

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. "Change the Personal Message" or "Friendly Name" fields cause a 
disconnection using a Provisional Account

What is the expected output? What do you see instead?
The expected output: See the changes in DotMSNClient and Windows Live Messenger 
that have this contact.
What do I see instead: The DotMSNClient changes to disconnected state after I 
leave the Personal Message or Friendly Name fields.

What version of the product are you using? (MSNPSharp, OS, Mono etc.)
MSNPSharp 4.0

Is your code check out from SVN or download from our download site?
SVN

Please provide any additional information below:
If you need a Provisional Account, please don't hesitate on requesting one to 
me via email

Thanks.

Original issue reported on code.google.com by chel...@gmail.com on 10 May 2011 at 8:50

GoogleCodeExporter commented 8 years ago
Please email me your provisional account to reproduce error:
hephappy@gmail  .  com

Original comment by hepha...@gmail.com on 11 May 2011 at 10:27

GoogleCodeExporter commented 8 years ago
I found the problem.
We want to change status and we send this command:

PUT 7 1019
Routing: 1.0
From: 1:test@agentbot.net;epid={1a433d82-c9c1-4be9-b999-6af8a21cda2a}
To: 1:test@agentbot.net

Reliability: 1.0
Flags: ACK
Stream: 1

Publication: 1.0
Content-Length: 775
Content-Type: application/user+xml
Uri: /user

<user><s n="IM"><Status>HDN</Status><CurrentMedia></CurrentMedia></s><s 
n="PE"><UserTileLocation><msnobj Creator="test@agentbot.net" Size="14034" 
Type="3" Location="MSNPSharpDefault" Friendly="AAA=" 
SHA1D="mvJgSYX/zyzTfgiTbQPtQZqGeuk=" SHA1C="Aj2l6eJ7sEKfmsJK8gnPNwdL0Tk=" 
/></UserTileLocation><FriendlyName></FriendlyName><RUM></RUM><PSM></PSM><DDP></D
DP><ColorScheme>-16777216</ColorScheme><Scene></Scene><SignatureSound></Signatur
eSound><CurrentMedia></CurrentMedia></s><sep 
n="IM"><Capabilities>2952954144:2558662528</Capabilities></sep><sep 
n="PE"><VER>MSNMSGR:15.4.3508.1109</VER><TYP>1</TYP><Capabilities>100663296:1142
538240</Capabilities></sep><sep 
n="PD"><ClientType>1</ClientType><EpName>ANDROMEDA-PC</EpName><Idle>false</Idle>
<State>HDN</State></sep></user>

But the response is:
PUT 7 OK 0

It must be:

NFY PUT 1290
Routing: 1.0\r\n
To: 1:test@agentbot.net\r\n
From: 1:test@agentbot.net\r\n
\r\n
Reliability: 1.0\r\n
\r\n
Notification: 1.0\r\n
NotifNum: 0\r\n
Uri: /user\r\n
NotifType: Partial\r\n
By: 1:test@agentbot.net;epid={57ebb4c1-9d80-401d-a88c-78ca34628fc7}\r\n
Content-Type: application/user+xml\r\n
Content-Length: 998\r\n
\r\n
<user><s n="IM"><Status>HDN</Status><CurrentMedia></CurrentMedia></s><s 
n="PE"><UserTileLocation><msnobj Creator="test@agentbot.net" Size="14034" 
Type="3" Location="MSNPSharpDefault" Friendly="AAA=" 
SHA1D="mvJgSYX/zyzTfgiTbQPtQZqGeuk=" SHA1C="w5oQiom4LbiF0s4Gc+0ukMM7TXw=" 
/></UserTileLocation><FriendlyName>MSNPSharp 
v4.0</FriendlyName><RUM></RUM><PSM>Fixed AppendChild bug: Can't change personal 
message.</PSM><DDP></DDP><ColorScheme>-16777216</ColorScheme><Scene></Scene><Sig
natureSound></SignatureSound><CurrentMedia></CurrentMedia></s><s 
n="PD"></s><sep n="IM" 
epid="{57ebb4c1-9d80-401d-a88c-78ca34628fc7}"><Capabilities>2952823072:255866252
8</Capabilities></sep><sep n="PE" 
epid="{57ebb4c1-9d80-401d-a88c-78ca34628fc7}"><VER>MSNMSGR:15.4.3508.1109</VER><
TYP>1</TYP><Capabilities>100663296:1142538240</Capabilities></sep><sep n="PD" 
epid="{57ebb4c1-9d80-401d-a88c-78ca34628fc7}"><ClientType>1</ClientType><EpName>
ANDROMEDA-PC</EpName><Idle>false</Idle><State>HDN</State></sep></user>

The problem is payload size is 0, so status cannot change and it is always 
offline.
We change status when we NFY PUT received, but for bots, it is PUT TransID OK 
0. Please wait my fix.

Original comment by hepha...@gmail.com on 12 May 2011 at 8:49

GoogleCodeExporter commented 8 years ago
This issue was updated by revision r2403.

Original comment by hepha...@gmail.com on 12 May 2011 at 9:49

GoogleCodeExporter commented 8 years ago
Thanks man, you really rock!

Original comment by chel...@gmail.com on 12 May 2011 at 2:36