search

supercollider-quarks / JITLibExtensions

Some extensions to the common JITLib classes
GNU General Public License v2.0
11 stars 9 forks source link

broadcastserver #8

Closed LFSaw closed 6 years ago

LFSaw commented 7 years ago
telephon commented 7 years ago

looks good. Have you thought through the consistency with the Node subclasses?

LFSaw commented 7 years ago

can you point me towards the Node subclasses you mean?

Reason for the change is that asTarget.server is used in Steno to determine the server to which a group is sent. returning homeserver breaks compatibility because the group is only created on the homeserver.

telephon commented 7 years ago

I was only slightly unsure about what happens if you use that group as a target for a synth or another group.

LFSaw commented 7 years ago

since steno uses this functionality extensively and I am using this patch since I created the PR, it is likely that it works.

telephon commented 7 years ago

ok. i guess we have to review broadcast server anyhow once we get multiple clients working correctly in server.

telephon commented 7 years ago

let's wait for the second review by @adcxyz

LFSaw commented 6 years ago

Having this in would really make my day.