search

supercollider / hidapi

A Simple library for communicating with USB and Bluetooth HID devices on Linux, Mac, and Windows.
http://www.signal11.us/oss/hidapi/
Other
13 stars 14 forks source link

Revert #16 #17

Closed dyfer closed 7 months ago

dyfer commented 1 year ago

It seems that #16 introduced a bug on Linux: https://github.com/supercollider/supercollider/issues/6016

I don't know why that would be. However, reverting #16 seems to fix the reported issue. In that case I proposed to revert that change, since I'm not aware of any other issues reported with HID in quite some time regarding the supposed memory leak.

I haven't tested this beyond confirming with the person who reported the issue in SC.

bgola commented 7 months ago

It seems like this should indeed be reverted.

Please check https://github.com/supercollider/hidapi/pull/16#issuecomment-2050183428 for an explanation