supercollider / sc3-plugins

Community plugins for SuperCollider
https://supercollider.github.io/sc3-plugins/
GNU General Public License v2.0
449 stars 122 forks source link

VBAP with more than 55 channels #374

Closed lexngu closed 3 months ago

lexngu commented 3 months ago

Hey there! I'm reaching out to kindly request the merging of my changes to the VBAP UGen to the central repository. This would be helpful for me and my fellow students at the Karlsruhe University of Music as we'd love to use it in rooms equipped with up to 64 loudspeakers. We currently rely on a fork that, in my opinion, needn't exist independently.

muellmusik commented 3 months ago

Hi @lexngu! Thanks for this. I've actually got a version of VBAP which dynamically allocates memory, and adds some other updates. Just need to clean it up and can do a PR. I think this would be better than just adjusting the hardcoded solution.

muellmusik commented 3 months ago

Added at #376. I suggest we merge that instead of this if there are no issues.

lexngu commented 3 months ago

Sure, thanks for approval, @telephon, and for your suggestion, @muellmusik ! I also prefer the dynamic memory allocation. I am looking forward to testing the next release!