search

supercrabtree / k

k is the new l, yo
1.78k stars 123 forks source link

add support for light shell/terminal themes #62

Open ninrod opened 8 years ago

ninrod commented 8 years ago

I'm using papercolor (light theme) on iTerm2 and have just installed k. It seems that k doesn't play nice with light themes.

I'm using OSx with coreutils installed so my ls command should behave as in GNU/Linux.

my full shell config can be seen here.

k-on-light-theme
supercrabtree commented 8 years ago

Hey, yes I am aware of this, I am currently slowly redoing the color handling, not really sure what to do about this particular problem at the moment. Problem is you only get 256 colors to play with.

As a quickfix to your problem, you could fork this and fiddle with the colors here: https://github.com/supercrabtree/k/blob/e94410b125d8b1efe9a425730fbecc0fa2e4a4d9/k.sh#L170-L181

ninrod commented 8 years ago

Ok, thank you for the gist

ELLIOTTCABLE commented 7 years ago

@supercrabtree what are your thoughts, here? For simply light-versus-dark, an environment variable is enough, I would think — the behaviour doesn't need to change, just the order (whether “light” or “dark” is considered faded-out and old).

Check out how Vim does it, which is far from perfect, but a start; also see the $COLORFGBG variable (although propagating support for that is problematic in its own way), and in particular, this synthesis of the above into shell-script.

fawaf commented 2 years ago

+1 to @ELLIOTTCABLE . even a simple light vs dark initial update would be great. then better color handling can happen afterwards.