Use codecvt for wide char conversion.

superctr / ctrmml

MML compiler

GNU General Public License v2.0

22 stars 4 forks source link

Use codecvt for wide char conversion. #7

Closed mmontag closed 3 years ago

mmontag commented 3 years ago

Hi, what are your thoughts on this? I was able to use this method to make the project compile on macOS.

Not sure if the style is good, or if it is a good idea to use codecvt, but it works.

I'm not sure how to test exporting a VGM with Unicode (👍)/Japanese (漢字) characters, because they show up in mmlgui itself and in the exported tags as ?.

superctr commented 3 years ago

Thanks for looking into this, and I think it looks good so far.

You can test by running make sample_mml in the ctrmml directory. The file sample/sand_light.mml contains Japanese tags that should be copied properly to the VGM file.

mmontag commented 3 years ago

Thanks! Do any of these contain Unicode in the English tags? I think my (game-music-emu based...) player is ignoring the Japanese tags completely.

superctr commented 3 years ago

No, I don't think so. But you can test by editing the mml files in a normal text editor. I recommend vgmplay-libvgm for playing back the VGM files.

mmontag commented 3 years ago

Finally got vgmplay to build. This appears to work as intended:

superctr commented 3 years ago

merged in 34f97584305795ed8751d34d2fb9d775c1e79f84