Updated dependencies (Angular and SirTrevor). ...

superdesk / ng-sir-trevor

Sir Trevor Angular services and directive, to work better with sir in ng enviroment.

GNU General Public License v3.0

4 stars 6 forks source link

Updated dependencies (Angular and SirTrevor). ... #9

Closed markwpearce closed 9 years ago

markwpearce commented 9 years ago

Also: Removed dependency on underscore. Recast directive element as jQuery. Added directive tests.

A few notes:

I replaced the underscore flavours of extend/clone/each with angular's (since it's already loaded!)
Angular directive's link function's element is now (always?) a jqLite element. This means it has to be re-cast as a jQuery element - hence the extra call to $() in link().
I needed to add a "bind" polyfil for phantomJS testing of directives

vied12 commented 9 years ago

Thank you @markwpearce !

But do you need something special from the sir-trevor version ~0.4.3 ? Because this version removed some useful events like block:create:existing and block:create:new. And it seems that version is pretty unstable. Even the doc recommends to install the version 0.3.0

markwpearce commented 9 years ago

I was unaware of the decremented features in Sir Trevor. I just updated to version 0.4.3 because that's the default version you get when you do:

bower install sir-trevor-js

which is what they recommend on their Github page.

It's probably not that important to use 0.4.x over 0.3.x, but they are using "sir-trevor-js" as their bower id now, not "sir-trevor", so that change is important.